Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Migrate to JUnit 5

Applies the OpenRewrite JUnit 5 migration recipe to migrate the project from JUnit 4 to JUnit 5 as described in issue #292.

The migration:

  • Updates all JUnit 4 annotations to JUnit 5 equivalents
  • Migrates assertions from hamcrest to org.junit.jupiter.api.Assertions
  • Converts @RunWith(Enclosed.class) to @nested classes
  • Updates Maven dependencies to use JUnit Jupiter instead of JUnit 4
  • Removes JUnit Vintage Engine
  • Adds OpenRewrite Maven plugin with JUnit 4 to 5 migration recipe

Note: There is an unrelated Doma version mismatch error in the sample-simple module that was present before this migration.

Resolves #292.

Link to Devin run: https://app.devin.ai/sessions/0f9c1d298f6b4736946b8f3d02c5c57b
Requested by: [email protected]

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@making
Copy link
Member

making commented May 18, 2025

@devin-ai-integration Avoid using public classes and public methods

@backpaper0 backpaper0 merged commit 64e373b into master May 19, 2025
6 checks passed
@backpaper0 backpaper0 deleted the devin/1747535396-junit5-migration branch May 19, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to JUnit 5

3 participants